Hi folks, The RNG uses a function called random_get_entropy() basically anytime that it needs to timestamp an event. For example, an interrupt comes in, and we mix a random_get_entropy() into the entropy pool somehow. Somebody mashes their keyboard or moves their mouse around? We mix a random_get_entropy() into the entropy pool. It's one of the main varieties of input. Unfortunately, it's always 0 on a few platforms. The RNG has accumulated various hacks to deal with this, but in general it's not great. Surely we can do better than 0. In fact, *anything* that's not the same exact value all the time would be better than 0. Even a counter that increments once per hour would be better than 0! I think you get the idea. On most platforms, random_get_entropy() is aliased to get_cycles(), which makes sense for platforms where get_cycles() is defined. RDTSC, for example, has all the characteristics we care about for this function: it's fast to acquire (i.e. acceptable in an irq handler), pretty high precision, available, forms a 2-monotone distribution, etc. But for platforms without that, what is the next best thing? Sometimes the next best thing is architecture-defined. For example, really old MIPS has the CP0 random register, which isn't a cycle counter, but is at least something. However, some platforms don't even have an architecture-defined fallback. In that case, what are we left with? By my first guess, we have ktime_get_boottime_ns(), jiffies, and sched_clock(). It seems like sched_clock() has already done a lot of work in being always available with some incrementing value, falling back to jiffies as necessary. So this series goes with that as a fallback, for when the architecture doesn't define random_get_entropy in its own way and when there's no working cycle counter. Another option would be falling back to different things on different platforms. For example, Arnd mentioned to me that on m68k, ktime_get_ns() might be better than sched_clock(), because it doesn't use CONFIG_GENERIC_SCHED_CLOCK and therefore is only as good as jiffies. Maybe there are other considerations there as well. This is a bit involved with plumbing asm/ headers, which is why this is an RFC. There are a few ways of skinning that cat. The patchset also tries to fill in the various cases where an arch only sometimes has a cycle counter and sometimes doesn't. When possible, it tries to make the decisions at compile time, but sometimes runtime decisions are necessary. Please let me know if you think this is sane. And if you have a different candidate than sched_clock(), I'd be interested to learn about that. In particular, I'd value input here from Thomas or somebody else who has looked at timekeeping across less common platforms. Finally, note that this series isn't about "jitter entropy" or other ways of initializing the RNG. That's a different topic for a different thread. Please don't let this discussion veer off into that. Here, I'm just trying to find a good fallback counter/timer for platforms without get_cycles(), a question with limited scope. Thanks, Jason Cc: Arnd Bergmann <arnd@xxxxxxxx> Cc: Theodore Ts'o <tytso@xxxxxxx> Cc: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> Cc: Russell King <linux@xxxxxxxxxxxxxxx> Cc: Catalin Marinas <catalin.marinas@xxxxxxx> Cc: Will Deacon <will@xxxxxxxxxx> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx> Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx> Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx> Cc: David S. Miller <davem@xxxxxxxxxxxxx> Cc: Richard Weinberger <richard@xxxxxx> Cc: Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Cc: Ingo Molnar <mingo@xxxxxxxxxx> Cc: Borislav Petkov <bp@xxxxxxxxx> Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> Cc: H. Peter Anvin <hpa@xxxxxxxxx> Cc: Chris Zankel <chris@xxxxxxxxxx> Cc: Max Filippov <jcmvbkbc@xxxxxxxxx> Cc: John Stultz <john.stultz@xxxxxxxxxx> Cc: Stephen Boyd <sboyd@xxxxxxxxxx> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Cc: linux-m68k@xxxxxxxxxxxxxxxxxxxx Cc: linux-mips@xxxxxxxxxxxxxxx Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx Cc: sparclinux@xxxxxxxxxxxxxxx Cc: linux-um@xxxxxxxxxxxxxxxxxxx Cc: x86@xxxxxxxxxx Cc: linux-xtensa@xxxxxxxxxxxxxxxx Jason A. Donenfeld (10): random: use sched_clock() for random_get_entropy() if no get_cycles() m68k: use sched_clock() for random_get_entropy() instead of zero riscv: use sched_clock() for random_get_entropy() instead of zero mips: use sched_clock() for random_get_entropy() instead of zero arm: use sched_clock() for random_get_entropy() instead of zero x86: use sched_clock() for random_get_entropy() instead of zero arm64: use sched_clock() for random_get_entropy() instead of zero um: use sched_clock() for random_get_entropy() instead of zero sparc: use sched_clock() for random_get_entropy() instead of zero xtensa: use sched_clock() for random_get_entropy() instead of zero arch/arm/include/asm/timex.h | 11 +++++++++++ arch/arm64/include/asm/timex.h | 9 +++++++++ arch/m68k/include/asm/timex.h | 4 +++- arch/mips/include/asm/timex.h | 3 ++- arch/riscv/include/asm/timex.h | 3 ++- arch/sparc/include/asm/timex_32.h | 4 +--- arch/um/include/asm/timex.h | 9 ++------- arch/x86/include/asm/tsc.h | 11 +++++++++++ arch/xtensa/include/asm/timex.h | 6 ++---- include/linux/timex.h | 6 ++++++ 10 files changed, 49 insertions(+), 17 deletions(-) -- 2.35.1
