On 3/30/22 7:03 AM, unSimple wrote: > OK, here is the new version. That won't do, your original patch description should be here. And it should be a fresh posting with [PATCH v2] in the subject. > Signed-off-by: QintaoShen <unSimple1993@xxxxxxx> > --- You need to describe what changes between v1 and v2 here... > arch/mips/sgi-ip22/ip22-gio.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c > index dfc52f6..f94f58b 100644 > --- a/arch/mips/sgi-ip22/ip22-gio.c > +++ b/arch/mips/sgi-ip22/ip22-gio.c > @@ -363,6 +363,10 @@ static void ip22_check_gio(int slotno, unsigned long addr, int irq) > printk(KERN_INFO "GIO: slot %d : %s (id %x)\n", > slotno, name, id); > gio_dev = kzalloc(sizeof *gio_dev, GFP_KERNEL); > + No need for empty line here. > +if (!gio_dev) > +return; Hm, the tabs were there but they got eaten when I replied. Your mail seems to be base64-encoded which I don't think is acceptable for patches -- they should be posted as plain text. [...] MBR, Sergey
