On Tue, Mar 15, 2022 at 12:46 AM Peter Xu <peterx@xxxxxxxxxx> wrote: > > On Fri, Mar 11, 2022 at 12:25:04AM +0000, David Matlack wrote: > > The parameter "direct" can either be true or false, and all of the > > callers pass in a bool variable or true/false literal, so just use the > > type bool. > > > > No functional change intended. > > > > Signed-off-by: David Matlack <dmatlack@xxxxxxxxxx> > > If we care about this.. how about convert another one altogether? > > TRACE_EVENT(kvm_hv_stimer_expiration, > TP_PROTO(int vcpu_id, int timer_index, int direct, int msg_send_result), > TP_ARGS(vcpu_id, timer_index, direct, msg_send_result), My preference would be to keep this commit specific to uses of "direct" that are related to shadow pages. The parameter `direct` in trace_kvm_hv_stimer_expiration() looks like it could be converted as well, but is a different concept altogether despite having the same variable name. > > Thanks, > > -- > Peter Xu >
