Re: [PATCH 2/3] MIPS: signal: Return immediately if call fails

[Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>]

On 12/18/2021 10:08 PM, Jiaxun Yang wrote:
> 在 2021/12/18 3:23, Tiezhu Yang 写道:
> > When debug sigaltstack(), copy_siginfo_to_user() fails first in
> > setup_rt_frame() if the alternate signal stack is too small, so
> > it should return immediately if call fails, no need to call the
> > following functions.
>
> Hi Tiezhu,
>
> Thanks for your patch.
> If we are doing so I see no reason for keeping the err variable.
> Just
>
> if (copy_siginfo_to_user(&frame->rs_info, &ksig->info))
>     return -EFAULT;
>
> seems much more clear.

OK, thank you, I will send v2 later.

Thanks,
Tiezhu

> Thanks.
>
> - Jiaxun