On Wed, Dec 1, 2021 at 9:24 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > On Fri, Nov 19, 2021 at 05:20:17PM -0600, Bjorn Helgaas wrote: > > > > Arnd added this with 37d6a0a6f470 ("PCI: Add > > pci_register_host_bridge() interface") [1]. > > > > I can't remember why this was done, but we did go to some trouble to > > move things around, so there must have been a good reason. > > > > Arnd or Thierry, do you remember? > > Nobody seems to remember, so I think we should go ahead and make this > change after the usual due diligence (audit the code between the old > site and the new site to look for any uses of bridge->windows). > > I think this would be material for v5.17. Sorry I forgot to reply to your earlier mail. I think this is fine, as far as I remember, the only reason the bridge windows are moved from the list and added back one at a time was to preserve the exact orderorks. We could probably even skip that step entirely and iterate throughing that was there originally, to keep the behavior after a series of reworks. We could probably even skip that step entirely and iterate through bridge->windows instead of the local list to simplify this. For Sergio's patch: Acked-by: Arnd Bergmann <arnd@xxxxxxxx>