On 11/27/21 02:18, Thomas Gleixner wrote:
Remove the kobject.h include from msi.h as it's not required and add a
sysfs.h include to the core code instead.
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
This patch breaks compile on powerpc :
CC arch/powerpc/kernel/msi.o
In file included from ../arch/powerpc/kernel/msi.c:7:
../include/linux/msi.h:410:65: error: ‘struct cpumask’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
410 | int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,
| ^~~~~~~
cc1: all warnings being treated as errors
Below is fix you can merge in patch 5.
Thanks,
C.
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -2,6 +2,7 @@
#ifndef LINUX_MSI_H
#define LINUX_MSI_H
+#include <linux/cpumask.h>
#include <linux/list.h>
#include <asm/msi.h>
---
include/linux/msi.h | 1 -
kernel/irq/msi.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -2,7 +2,6 @@
#ifndef LINUX_MSI_H
#define LINUX_MSI_H
-#include <linux/kobject.h>
#include <linux/list.h>
#include <asm/msi.h>
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -14,6 +14,7 @@
#include <linux/irqdomain.h>
#include <linux/msi.h>
#include <linux/slab.h>
+#include <linux/sysfs.h>
#include <linux/pci.h>
#include "internals.h"
