On Mon, Nov 15, 2021 at 08:08:04AM +0100, Sergio Paracuellos wrote: > Hi all, > > MIPS specific code can be removed from driver and put into ralink mt7621 > instead which is a more accurate place to do this. To make this possible > we need to have access to 'bridge->windows' in 'pcibios_root_bridge_prepare()' > which has been implemented for ralink mt7621 platform (there is no real > need to implement this for any other platforms since those ones haven't got > I/O coherency units). This also allow us to properly enable this driver to > completely be enabled for COMPILE_TEST. This patchset appoarch: > - Move windows list splice in 'pci_register_host_bridge()' after function > 'pcibios_root_bridge_prepare()' is called. > - Implement 'pcibios_root_bridge_prepare()' for ralink mt7621. > - Avoid custom MIPs code in pcie-mt7621 driver. > - Add missing 'MODULE_LICENSE()' to pcie-mt7621 driver to avoid compile test > module compilation to complain (already sent patch from Yanteng Si that > I have rewrite commit message and long description a bit. > - Remove MIPS conditional code from Kconfig. > > This patchset also fix some errors reported by Kernel Test Robot about > implicit mips functions used in driver code and fix errors in driver when > is compiled as a module [1] (mips:allmodconfig). > > There was an ongoing discussion about this here [0] but I preferred to send > my proposal for better review and understanding: so what's the plan with this patchset ? Going in as fix, probably via pci tree ? Or is material for next release ? If the latter can we first fix the allmodconfig by making the Kconfig symbol bool ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
