On 11/14/21 8:59 AM, Jonathan Cameron wrote:
On Sun, 14 Nov 2021 08:34:44 -0800
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
clk_get_parent(), so add a simple implementation of that
function so that callers of it will build without errors.
Fixes these build errors:
mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
I wonder a bit if it makes sense to fix only the ones we hit given there
look to be other missing definitions in this subarch.
clk_has_parent() for example appears to also be missing.
I haven't seen any failures for clk_has_parent().
I'm not actively looking for build errors; I'm just fixing
reported problems (usually and in this case).
There are plenty of them being reported without me having
to go looking for more.
Do we have the same issue with mips/lantiq?
Yes, now that you made me look. :)
Now I'll have to send a patch for that subarch also.
--
~Randy
