On Thu, Oct 21, 2021 at 06:04:12PM +0100, Marc Zyngier wrote: > Also loongson64 calls irq_cpu_offline(), none of its interrupt > controllers implement the .irq_cpu_offline callback. > > It is thus obvious that this call only serves the dubious purpose > of wasting precious CPU cycles by iterating over all interrupts. > > Get rid of the call altogether. > > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx> > --- > arch/mips/loongson64/smp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c > index 09ebe84a17fe..660e1de4412a 100644 > --- a/arch/mips/loongson64/smp.c > +++ b/arch/mips/loongson64/smp.c > @@ -550,7 +550,6 @@ static int loongson3_cpu_disable(void) > set_cpu_online(cpu, false); > calculate_cpu_foreign_map(); > local_irq_save(flags); > - irq_cpu_offline(); > clear_c0_status(ST0_IM); > local_irq_restore(flags); > local_flush_tlb_all(); > -- > 2.30.2 Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
