On Thu, 2 Sep 2021, Marc Kleine-Budde wrote:
> > > Starting with following patch MIPS Malta is not able to boot:
> > > | commit 79edff12060fe7772af08607eff50c0e2486c5ba
> > > | Author: Rob Herring <robh@xxxxxxxxxx>
> > > | scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9
>
> If the above patch broke malts, IMHO the fixes tag should be:
>
> Fixes: 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")
It's not clear either from this patch description or from the commit
referred what the actual *purpose* of the alignment check is and therefore
I think it's hard to say which of the two commits needs to be indicated as
the offender. Without further data I tend to agree it's 79edff12060f that
ought to be referred, being the immediate cause of the regression, as
things obviously worked before, for 5+ years.
> > > The reason is the alignment test added to the fdt_ro_probe_(). To fix
> > > this issue, we need to make sure that fdt_buf is aligned.
> > >
> > > Since the dtc patch was designed to uncover potential issue, I handle
> > > initial MIPS Malta patch as initial bug.
> > >
> > > Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> > > ---
> > > arch/mips/mti-malta/malta-dtshim.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > applied to mips-next.
>
> Please add stable on Cc, as Malta is broken since v5.12
> (79edff12060f == v5.12-rc1~104^2~10^2~3).
That for sure.
Maciej
