On Sun, Aug 08, 2021 at 02:08:29AM +0300, Vladimir Oltean wrote: > Hi Oleksij, > > On Mon, Aug 02, 2021 at 03:10:36PM +0200, Oleksij Rempel wrote: > > This switch is providing forwarding matrix, with it we can configure > > individual bridges. Potentially we can configure more than one not VLAN > > based bridge on this HW. > > > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> > > Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > > --- > > I don't see anywhere in this patch or in this series that the > tag_ar9331.c file is being patched to set skb->offload_fwd_mark to true > for packets sent (flooded) to the CPU that have already been forwarded > by the hardware switch. If the software bridge sees a broadcast packet > coming from your driver and it has offload_fwd_mark = false, it will > forward it a second time and the other nodes in your network will see > duplicates. Ok, thank you, I'll take a look on it. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |