On Wed, Jul 21, 2021 at 9:17 AM Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> wrote: > > On Mon, Jul 19, 2021 at 11:10:55PM +0100, Paul Cercueil wrote: > > > > #ifndef TOOLCHAIN_SUPPORTS_VIRT > > > > > > Same question for GAS version support for virt? > > > Documentation/process/changes.rst > > > says GNU binutils 2.23+ is required for building the kernel. > > > If we still need to support, have you tested this change on such an > > > older version of GNU binutils? > > > > I have no idea about virt support - I hope Thomas can answer this. > > virt support was added in 2.24 and xpa in 2.25. So we still need the > TOOLCHAIN defines for it. Ah, ok then. Thanks for finding that. Perhaps Paul you can note that in the v2 that removes the commented out line, then we should be good to go? -- Thanks, ~Nick Desaulniers
