Re: [PATCH v5 2/2] MIPS: Loongson64: Add pm block node for Loongson-2K1000

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 2021/6/29 上午9:19, Qing Zhang 写道:
The module is now supported, enable it.

Signed-off-by: Qing Zhang <zhangqing@xxxxxxxxxxx>
---

v4-v5:
add missing spaces

  arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
index 569e814def83..38bf14f00694 100644
--- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
+++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
@@ -101,6 +101,16 @@ uart0: serial@1fe00000 {
  			no-loopback-test;
  		};
+ pm: power-controller {
^ power-management@1fe0700c
+			device_type = "power management";
^ Why do you need to specify device type?
+			compatible = "loongson, reset-controller";
^ why space?
I guess it should be loongson,ls2k-pm...

- Jiaxun
+
+			reg = <0 0x1fe0700c 0 0x8>,
+			      <0 0x1fe07014 0 0x8>,
+			      <0 0x1fe07030 0 0x8>;
+			reg-names = "pm1_sts", "pm1_cnt", "rst_cnt";
^ I guess there is no need to specify three reg names, you can simply tell driver 0x1fe07000
base address and calculate them on your own.

Thanks.

- Jiaxun
+		};
+
  		pci@1a000000 {
  			compatible = "loongson,ls2k-pci";
  			device_type = "pci";




[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux