On Sun, May 16, 2021 at 05:54:17PM -0700, Randy Dunlap wrote: > rt2880_wdt.c uses (well, attempts to use) rt_sysc_membase. However, > when this watchdog driver is built as a loadable module, there is a > build error since the rt_sysc_membase symbol is not exported. > Export it to quell the build error. > > ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined! > > Fixes: 473cf939ff34 ("watchdog: add ralink watchdog driver") > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > Cc: Wim Van Sebroeck <wim@xxxxxxxxx> > Cc: John Crispin <john@xxxxxxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxxx > Cc: linux-watchdog@xxxxxxxxxxxxxxx > --- > or make the Kconfig symbol RALINK_WDT bool instead of tristate? > > arch/mips/ralink/of.c | 2 ++ > 1 file changed, 2 insertions(+) applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]