On Mon, Apr 19, 2021 at 11:39:43PM -0700, Ilya Lipnitskiy wrote:
> This mostly reverts commit 99bca615d895 ("MIPS: pci-legacy: use generic
> pci_enable_resources"). Fixes regressions such as:
> ata_piix 0000:00:0a.1: can't enable device: BAR 0 [io 0x01f0-0x01f7] not
> claimed
> ata_piix: probe of 0000:00:0a.1 failed with error -22
>
> The only changes from the strict revert are to fix checkpatch errors:
> ERROR: spaces required around that '=' (ctx:VxV)
> #33: FILE: arch/mips/pci/pci-legacy.c:252:
> + for (idx=0; idx < PCI_NUM_RESOURCES; idx++) {
> ^
>
> ERROR: do not use assignment in if condition
> #67: FILE: arch/mips/pci/pci-legacy.c:284:
> + if ((err = pcibios_enable_resources(dev, mask)) < 0)
>
> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@xxxxxxxxx>
> ---
> Guenter, sorry about this - let's just revert this for now to minimize
> turmoil to the legacy PCI code. Obviously, this needs more testing
> before applying. Thanks for your report!
>
> arch/mips/pci/pci-legacy.c | 38 +++++++++++++++++++++++++++++++++++++-
> 1 file changed, 37 insertions(+), 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
