On Thu, Apr 15, 2021 at 01:06:43AM +0200, Thomas Bogendoerfer wrote: > Get rid of access to struct korina_device by just passing the mac > address via platform data and use drvdata for passing netdev to remove > function. > > Signed-off-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > --- > arch/mips/rb532/devices.c | 5 +++-- > drivers/net/ethernet/korina.c | 11 ++++++----- > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/arch/mips/rb532/devices.c b/arch/mips/rb532/devices.c > index dd34f1b32b79..5fc3c8ee4f31 100644 > --- a/arch/mips/rb532/devices.c > +++ b/arch/mips/rb532/devices.c > @@ -105,6 +105,9 @@ static struct platform_device korina_dev0 = { > .name = "korina", > .resource = korina_dev0_res, > .num_resources = ARRAY_SIZE(korina_dev0_res), > + .dev = { > + .platform_data = &korina_dev0_data.mac, > + } This is a bit unusual. Normally you define a structure in include/linux/platform/data/koriana.h, and use that. What about the name? "korina0" How is that passed? Andrew