On Tue, Apr 06, 2021 at 09:24:43AM +0200, Christoph Hellwig wrote: > Btw, there is a bunch of cleanups that would fit in nicely on top of > this: > > - remove the unused __invoke_copy_from function I've removed in the last patch before applying to mips-next. > - fold __get_user_check into get_user as it is the only caller > - fold __get_user_nocheck into __get_user as it is the only caller > - fold __put_user_check into put_user as it is the only caller > - fold __put_user_nocheck into __put_user as it is the only caller > - implement get_user in terms of __get_user to document the difference > better and to remove __get_user_common > - implement put_user in terms of __put_user to document the difference > better and to remove __get_user_common > - remove __put_user_unknown/__get_user_unknown and replace them with > BUILD_BUG_ON() I'll prepare a follow-up patch. Thank you for your cleanup hints. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]