On Mon, 22 Mar 2021, YunQiang Su wrote: > Currently, FR=1 mode is used for all FPXX binary if O32_FP64 supported is enabled, > it makes some wrong behivour of the binaries. > Since FPXX binary can work with both FR=1 and FR=0, we force it to use FR=0. Even if it is given a go-ahead from the semantic point of view, your change still suffers from style issues. I find the change description inaccurate or unclear in some places (I can help with that, but not before code itself has been accepted), and the change has overlong lines both in the body (the limit is 80 columns) and the description (the limit is 75 columns). It's not clear to me why `scripts/checkpatch.pl' only complains about one place, but you need to fix them all. If you haven't so far, please familiarise yourself with the documents describing patch submission: Documentation/process/coding-style.rst and Documentation/process/submitting-patches.rst available in the kernel tree. They document the line length limits given above and all the other aspects of code preparation for submission. Maciej
