Hello, Cleaned up the commit message and added reviewed-by, tested-by and Cc: tags. Cheers, Mauri -- Notes v2: - errorneous proposal to revert whole commit. withdrawn. v3: - as v1. - Added Reviewed-by: and Tested-By for Thomas Bogendoerfer - reworded commit message - added Cc: trivial@xxxxxxxxxx rangediff v1...v3 1: cff3565c8f48 ! 1: e4e83543be07 MIPS: kernel: setup.c: fix compilation error @@ Metadata ## Commit message ## MIPS: kernel: setup.c: fix compilation error - Developing against mips/mips-next I get a compilation error. - With the attached patch compilation succeeds. + With ath79_defconfig enabling CONFIG_MIPS_ELF_APPENDED_DTB gives a + compilation error. This patch fixes it. Build log: ... @@ Commit message CC fs/attr.o make[4]: *** [../scripts/Makefile.build:271: arch/mips/kernel/setup.o] Error 1 - make[3]: *** [../scripts/Makefile.build:514: arch/mips/kernel] Error 2 - make[2]: *** [/home/ubuntu/git/linux/Makefile:1849: arch/mips] Error 2 - make[2]: *** Waiting for unfinished jobs.... ... Root cause seems to be: - commit b83ba0b9df56 ("MIPS: of: Introduce helper function to get DTB") + Fixes: b83ba0b9df56 ("MIPS: of: Introduce helper function to get DTB") Signed-off-by: Mauri Sandberg <sandberg@xxxxxxxxxxxxx> + Reviewed-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> + Tested-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> + Cc: trivial@xxxxxxxxxx ## arch/mips/kernel/setup.c ## @@ Mauri Sandberg (1): MIPS: kernel: setup.c: fix compilation error arch/mips/kernel/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 19f0e8cddf0f136112acaaf02dab2cee35b56439 -- 2.25.1