On 15/03/2021 15:15:43+0800, Yang Li wrote: > fixed the following coccicheck: > ./arch/mips/generic/board-ocelot.c:29:9-10: WARNING: return of 0/1 in > function 'ocelot_detect' with return type bool > Can you elaborate why this is an issue and what exactly is fixed? Even the original coccinelle script submission doesn't give any good reason. bool in Linux is _Bool and, as per C99, it holds either 0 or 1, not true or false. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com