Re: [PATCH v8] block: Add n64 cart driver

[Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx>]

On 1/21/21 4:13 AM, Lauri Kasanen wrote:
> +
> +#define PI_DRAM_REG 0
> +#define PI_CART_REG 1
> +#define PI_READ_REG 2
> +#define PI_WRITE_REG 3
> +#define PI_STATUS_REG 4
> +
> +#define PI_STATUS_DMA_BUSY (1 << 0)
> +#define PI_STATUS_IO_BUSY (1 << 1)
> +
> +#define CART_DOMAIN 0x10000000
> +#define CART_MAX 0x1FFFFFFF

I'd align macro definitions with tabs :-

#define PI_STATUS_DMA_BUSY      (1 << 0)
#define PI_STATUS_IO_BUSY       (1 << 1)

#define CART_DOMAIN             0x10000000
#define CART_MAX                0x1FFFFFFF