On Tue, Jan 19, 2021 at 06:56:48PM +0800, Kevin Hao wrote: > > .... IMHO the real bug is d9df9fb901d2 MIPS: Octeon: Remove special handling > > of CONFIG_MIPS_ELF_APPENDED_DTB=y. I'm tending to simply revert that commit. > > Yes, this indeed seem much better. I will send a patch to revert d9df9fb901d2. > Another issue is that the name of fw_passed_dtb seems pretty confusion after the > change of commit 37e5c69ffd41. Could we rename it to something like final_dtb_addr? this wouldn't make the mess smaller, IMHO. My idea is to add a helper function, which deals with all the possible sources of dtbs, which could be used instead of fw_passed_dtb. This gets rid of the ugly #ifdefry in head.S and hopefull makes future changes less error prone. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
