On Mon, Jan 18, 2021 at 06:02:08PM +0800, Jinyang He wrote: > On 01/15/2021 10:46 PM, Thomas Bogendoerfer wrote: > > > On Tue, Jan 12, 2021 at 08:29:14PM +0800, Jinyang He wrote: > > > Just reorder the header files. > > This alone isn't worth a commit, IMHO. I bet there are lots of includes > > no longer needed, so removing and sorting them is ok for me. > > > > Thomas. > > > > Hi, Thomas, > > Thanks for your advice. I analyzed majority of the symbols in this file. > The following are examples of header file references: > > Space indicates that it cannot be found. (Maybe I missed it.) > > Header files Examples in this file > #include <linux/completion.h> > * #include <linux/cpu.h> get_online_cpus > * #include <linux/errno.h> EOPNOTSUPP > [..] thank you for doing this. > By including only these header files which marked by '*', I have been able > to compile and use certain functions (unwind_stack) normally. So are other > header files no longer needed? > > In addition, <linux/cpu.h> includes <linux/cpumask.h>, and <linux/cpumask.h> > includes <linux/kernel.h>. What should we do? send a patch, which deletes the not needed #includes ;-) Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
