Re: [PATCH] mips: cacheinfo: Remove unnecessary increment of level

[Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>]

在 2021/1/16 下午4:40, Souptick Joarder 写道:
> kernel test robot throws below warning ->
>
> arch/mips/kernel/cacheinfo.c:112:3: warning: Variable 'level' is
> modified but its new value is never used. [unreadVariable]
>
> Remove unnecessary increment of level at the end.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>

Reviewed-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>

> ---
>   arch/mips/kernel/cacheinfo.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/kernel/cacheinfo.c b/arch/mips/kernel/cacheinfo.c
> index 5f9d0eb..c858ae3 100644
> --- a/arch/mips/kernel/cacheinfo.c
> +++ b/arch/mips/kernel/cacheinfo.c
> @@ -109,7 +109,6 @@ static int __populate_cache_leaves(unsigned int cpu)
>   
>   	if (c->tcache.waysize) {
>   		populate_cache(tcache, this_leaf, level, CACHE_TYPE_UNIFIED);
> -		level++;
>   	}
>   
>   	this_cpu_ci->cpu_map_populated = true;