On Fri, 08 Jan 2021 10:06:48 +0100 Takashi Iwai <tiwai@xxxxxxx> wrote: > > +static int __init n64audio_probe(struct platform_device *pdev) > > Usually the probe callback itself shouldn't be __init. > > > +fs_initcall(n64audio_init); > > Does it have to be this initcall? It could be module init instead, nothing specific in fs_initcall. It's __init because it can only be compiled in, and removing that run-once code saves RAM. The target only has 8mb RAM. - Lauri
