On Thu, Jan 07, 2021 at 03:36:45PM +0100, Andrew Lunn wrote: > > +static void ar9331_get_stats64(struct dsa_switch *ds, int port, > > + struct rtnl_link_stats64 *s) > > +{ > > + struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv; > > + struct ar9331_sw_port *p = &priv->port[port]; > > + > > + spin_lock(&p->stats_lock); > > + memcpy(s, &p->stats, sizeof(*s)); > > + spin_unlock(&p->stats_lock); > > +} > > This should probably wait until Vladimir's changes for stat64 are > merged, so this call can sleep. You can then return up to date > statistics. Ack, no problem. Beside, i forgot to collect all the Reviewed-by tags. Will resend all needed changes after Vladimirs patches are accepted. May be the "net: dsa: add optional stats64 support" can already be taken? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |