On Tue, Jan 05, 2021 at 01:18:27PM -0700, Nathan Chancellor wrote: > When building xway_defconfig with clang: > > arch/mips/lantiq/prom.c:82:23: error: array comparison always evaluates > to true [-Werror,-Wtautological-compare] > else if (__dtb_start != __dtb_end) > ^ > 1 error generated. > > These are not true arrays, they are linker defined symbols, which are > just addresses. Using the address of operator silences the warning > and does not change the resulting assembly with either clang/ld.lld > or gcc/ld (tested with diff + objdump -Dr). Do the same thing across > the entire MIPS subsystem to ensure there are no more warnings around > this type of comparison. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1232 > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx> > --- > arch/mips/bmips/setup.c | 2 +- > arch/mips/lantiq/prom.c | 2 +- > arch/mips/pic32/pic32mzda/init.c | 2 +- > arch/mips/ralink/of.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
