On Mon, Dec 28, 2020 at 10:59:38AM +0800, Qing Zhang wrote: > + if (!!(spi->mode & SPI_CS_HIGH) == enable) > + ls7a_spi_write_reg(ls7a_spi, SFC_SOFTCS, (0x1 << spi->chip_select) | cs); > + else > + ls7a_spi_write_reg(ls7a_spi, SFC_SOFTCS, (0x11 << spi->chip_select) | cs); > +} The core will handle inverting the chip select for the driver when SIP_CS_HIGH so doing it again here will cause bugs. Just use the value of enable directly. Otherwise this looks good.
Attachment:
signature.asc
Description: PGP signature
