On Mon, Jan 04, 2021 at 06:01:15PM +0200, Lauri Kasanen wrote:
> On Mon, 4 Jan 2021 07:49:02 -0800
> Keith Busch <kbusch@xxxxxxxxxx> wrote:
>
> > On Mon, Jan 04, 2021 at 03:50:31PM +0200, Lauri Kasanen wrote:
> > > block folks: rest of the series is on linux-mips. Being a mips-specific driver,
> > > not sure which tree it should go to.
> >
> > Probably through mips.
>
> Thanks.
To be more clear, the initial commit probably makes since to go through
mips once the series is ready, but new block drivers do need to be sent
to linux-block for the appropriate acks and reviews first.
> > > +static blk_status_t get_seg(struct request *req)
> > > +{ > > > + u32 bstart = blk_rq_pos(req) * 512;
> > > + u32 len = blk_rq_cur_bytes(req);
> > > + void *dst = bio_data(req->bio);
> > > +
> > > + if (bstart + len > size || rq_data_dir(req) == WRITE)
> > > + return BLK_STS_IOERR;
> >
> > If you don't support writes (is that limitation temporary?), then you
> > can prevent such operations from reaching the driver by setting the
> > "disk" to read-only during initialization with set_disk_ro(disk, true).
>
> The media is read-only (but not runtime removable).
It's been a while, but I could swear we can save state on these carts.
If so, it sounds like that must be separate from the media this driver
is accessing, so is that capability provided through a different driver?
