On 1/4/21 8:43 AM, Lauri Kasanen wrote: > On Mon, 4 Jan 2021 08:40:10 -0700 > Jens Axboe <axboe@xxxxxxxxx> wrote: > >> On 1/4/21 6:50 AM, Lauri Kasanen wrote: >>> Signed-off-by: Lauri Kasanen <cand@xxxxxxx> >>> --- >>> drivers/block/Kconfig | 6 ++ >>> drivers/block/Makefile | 1 + >>> drivers/block/n64cart.c | 203 ++++++++++++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 210 insertions(+) >>> create mode 100644 drivers/block/n64cart.c >>> >>> block folks: rest of the series is on linux-mips. Being a >>> mips-specific driver, not sure which tree it should go to. >> >> It should definitely get reviewed first. One easy question - there's no >> commit message in this one. It's a new driver, it should include some >> documentation on what it is, etc. > > It's already had one (rfc) round on linux-mips. Or do you mean by > others (who?) I mean the actual block driver from the block point of view. From a quick look, looks like there's no irq or anything, so it's strictly polled mode? Probably would make sense to push this out of the app path then, by using BLK_MQ_F_BLOCKING. -- Jens Axboe
