Hi Alexandre, On Mon, Jan 4, 2021 at 3:48 PM Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> wrote: > On 04/01/2021 14:28:26+0100, Geert Uytterhoeven wrote: > > On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> wrote: > > > Goldfish platform is covered with dust. > > > However the goldfish-rtc had been used as virtualized RTC > > > in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus > > > we can drop other parts of goldfish but leave goldfish-rtc here. > > > > > > Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > > > > Thanks for your patch! > > > > > --- a/drivers/rtc/Kconfig > > > +++ b/drivers/rtc/Kconfig > > > @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME > > > config RTC_DRV_GOLDFISH > > > tristate "Goldfish Real Time Clock" > > > depends on OF && HAS_IOMEM > > > - depends on GOLDFISH || COMPILE_TEST > > > help > > > Say yes to enable RTC driver for the Goldfish based virtual platform. > > > > I was just looking to see if someone had already sent a patch to add > > "depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I > > noticed your patch had removed it... > > > > What about > > > > depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST > > > > instead? > > > > But this driver also works on ARM, is it really important to restrict to > a few architectures ? Is it used on ARM platforms? qemu:hw/riscv/Kconfig selects GOLDFISH_RTC, but that's it? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds