On Fri, Dec 18, 2020 at 12:27:32AM +0100, Bert Vermeulen wrote: > On 12/15/20 11:11 PM, Oleksij Rempel wrote: > > Hello Bert, > > > > thank you for your work. Here are some comments.. > > Thanks for reviewing. I will send in a V2 with your comments all handled. > > > I assume, after applying all needed changes, there will be no files within > > arch/mips/include/asm/mach-realtek :) > > I wish! Unfortunately I need somewhere to put the early printk init call, > and the SoC family ID checks -- as they are heavily used in various drivers. just as a prevention, don't put realtek specific files into mach-realtek, but only use realtek as directory name. The mach-xxx directories are special and I have a mission on my todo to move the non-special files into their own directores... Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]