On Thu, Dec 03, 2020 at 11:03:36PM +0000, Al Viro wrote: > On Thu, Dec 03, 2020 at 02:09:04PM -0800, Linus Torvalds wrote: > > On Thu, Dec 3, 2020 at 1:46 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > > > > > The answer (for mainline) is that mips compat does *NOT* want > > > COMPAT_BINFMT_ELF. Not a problem with that series, though, so I'd > > > retested it (seems to work, both for x86_64 and mips64, execs and > > > coredumps for all ABIs alike), with centralization of Kconfig logics > > > thrown in. > > > > Well, the diffstat looks nice: > > > > > 26 files changed, 127 insertions(+), 317 deletions(-) > > > > and the patches didn't trigger anything for me, but how much did this > > get tested? Do you actually have both kinds of 32-bit elf mips > > binaries around and a machine to test on? > > Yes (aptitude install gcc-multilib on debian mips64el/stretch sets the toolchain > and libraries just fine, and then it's just a matter of -mabi=n32 passed > to gcc). "Machine" is qemu-system-mips64el -machine malta -m 1024 -cpu 5KEc > and the things appear to work; I hadn't tried that on the actual hardware. > I do have a Loongson-2 box, but it would take a while to dig it out and > get it up-to-date. > > > Linux-mips was cc'd, but I'm adding Thomas B to the cc here explicitly > > just so that he has a heads-up on this thing and can go and look at > > the mailing list in case it goes to a separate mailbox for him.. > > I would certainly appreciate review and testing - this branch sat > around in the "should post it someday" state since June (it was > one of the followups grown from regset work back then), and I'm > _not_ going to ask pulling it without an explicit OK from mips > folks. I've tested it on real hardware and so far everything looks good. You can add my Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> for the MIPS part. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
