On Fri, 11 Dec 2020 11:53:21 +0100 Oleksij Rempel wrote: > +static void dsa_slave_get_stats64(struct net_device *dev, > + struct rtnl_link_stats64 *s) > +{ > + struct dsa_port *dp = dsa_slave_to_port(dev); > + struct dsa_switch *ds = dp->ds; > + > + if (!ds->ops->get_stats64) > + return dev_get_tstats64(dev, s); > + > + return ds->ops->get_stats64(ds, dp->index, s); nit: please don't return void, "else" will do just fine here