On Tue, Nov 17, 2020 at 10:05:18AM +0200, Mike Rapoport wrote: > On Mon, Nov 16, 2020 at 11:05:54PM +0300, Serge Semin wrote: > > On Mon, Nov 16, 2020 at 06:45:15PM +0100, Thomas Bogendoerfer wrote: > > > The loop over all memblocks works with PFN numbers and not physical > > > addresses, so we need for_each_mem_pfn_range(). > > > > Great catch! Don't know how that has been working so far. Anyway > > The loop is relevant only for systems with highmem, apparently there are > not many highmem users out there. I found the bug on a SGI IP22 probably because PHYS_OFFSET is != 0. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]