Re: [patch V3 24/37] sched: highmem: Store local kmaps in task struct

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: LKML <linux-kernel@xxxxxxxxxxxxxxx>

Subject: Re: [patch V3 24/37] sched: highmem: Store local kmaps in task struct

From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Date: Tue, 03 Nov 2020 14:49:44 +0100

Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Paul McKenney <paulmck@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Benjamin LaHaise <bcrl@xxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-aio@xxxxxxxxx, Chris Mason <clm@xxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, Vineet Gupta <vgupta@xxxxxxxxxxxx>, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, Michal Simek <monstr@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx, Nick Hu <nickhu@xxxxxxxxxxxxx>, Greentime Hu <green.hu@xxxxxxxxx>, Vincent Chen <deanbo422@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, sparclinux@xxxxxxxxxxxxxxx, Chris Zankel <chris@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, linux-xtensa@xxxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>, Dietmar Eggemann <dietmar.eggemann@xxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Ben Segall <bsegall@xxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>, Christian Koenig <christian.koenig@xxxxxxx>, Huang Rui <ray.huang@xxxxxxx>, David Airlie <airlied@xxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, VMware Graphics <linux-graphics-maintainer@xxxxxxxxxx>, Roland Scheidegger <sroland@xxxxxxxxxx>, Dave Airlie <airlied@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, spice-devel@xxxxxxxxxxxxxxxxxxxxx, Ben Skeggs <bskeggs@xxxxxxxxxx>, nouveau@xxxxxxxxxxxxxxxxxxxxx, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, intel-gfx@xxxxxxxxxxxxxxxxxxxxx

In-reply-to: <20201103095859.038791330@linutronix.de>

References: <20201103092712.714480842@linutronix.de> <20201103095859.038791330@linutronix.de>

On Tue, Nov 03 2020 at 10:27, Thomas Gleixner wrote:
> +struct kmap_ctrl {
> +#ifdef CONFIG_KMAP_LOCAL
> +	int				idx;
> +	pte_t				pteval[KM_TYPE_NR];

I'm a moron. Fixed it on the test machine ...