On 10/20/20 8:51 AM, Randy Dunlap wrote: > On 10/20/20 7:06 AM, Randy Dunlap wrote: >> On 10/20/20 1:02 AM, Christoph Hellwig wrote: >>> On Sun, Oct 18, 2020 at 11:14:53PM -0700, Randy Dunlap wrote: >>>> Fix a build error in drivers/mfd/ioc.o by exporting >>>> pci_find_host_bridge(). >>>> >>>> ERROR: modpost: "pci_find_host_bridge" [drivers/mfd/ioc3.ko] undefined! >>> >>> I think the mfd code should be fixed to not depend on such an internal >>> symbol instead. >>> >> >> Thanks for commenting. and I am not surprised. >> >> Adding Cc: for Thomas and Lee. > > BTW, if someone wants to use the MFD ioc3 driver now, > without any source code patches, they can just build it in > (SGI_MFD_IOC3=y) instead of building it as a loadable module. > > It builds successfully and can use pci_find_host_bridge(). > pci_find_host_bridge() just isn't exported for loadable modules. > > So this could be useful (PCI=y): > > config SGI_MFD_IOC3 > tristate "SGI IOC3 core driver" > depends on PCI=y && MIPS && 64BIT > select MFD_CORE Wow. That's not correct at all. Need more coffee. Just set SGI_MFD_IOC3=y and it will be fine. -- ~Randy
