On Thu, Aug 20, 2020 at 08:54:40PM +0800, zhe.he@xxxxxxxxxxxxx wrote: > From: He Zhe <zhe.he@xxxxxxxxxxxxx> > > We want neither > " > include/linux/compiler_attributes.h:201:41: warning: statement will never > be executed [-Wswitch-unreachable] > 201 | # define fallthrough __attribute__((__fallthrough__)) > | ^~~~~~~~~~~~~ > " > nor > " > include/linux/compiler_attributes.h:201:41: warning: attribute > 'fallthrough' not preceding a case label or default label > 201 | # define fallthrough __attribute__((__fallthrough__)) > | ^~~~~~~~~~~~~ > " > > It's not worth adding one more macro. Let's simply place the fallthrough > in between the expansions. > > Signed-off-by: He Zhe <zhe.he@xxxxxxxxxxxxx> there is already another patch for the problem, which I've applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
