Re: metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 07, 2018 at 09:50:31AM +0100, Michal Hocko wrote:
> On Sat 06-01-18 17:07:33, Guenter Roeck wrote:
> > The following build error is seen when building metag:meta2_defconfig
> > or metag:tz1090_defconfig.
> > 
> > arch/metag/kernel/process.c: In function '__metag_elf_map':
> > arch/metag/kernel/process.c:421: error: 'tsk' undeclared
> 
> Sorry about that and thanks for your report. The following should fix
> the issue. Andrew, could you fold it to the original patch please?
> ---
> From 64da2e0c134ecf3936a4c36b949bcf2cdc98977e Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@xxxxxxxx>
> Date: Sun, 7 Jan 2018 09:47:41 +0100
> Subject: [PATCH] fs-elf-drop-map_fixed-usage-from-elf_map-fix-fix
> 
> The following build error is seen when building metag:meta2_defconfig
> or metag:tz1090_defconfig.
> 
> arch/metag/kernel/process.c: In function '__metag_elf_map':
> arch/metag/kernel/process.c:421: error: 'tsk' undeclared
> 
> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>

Compiled and booted with qemu.

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Guenter

> ---
>  arch/metag/kernel/process.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
> index 9e007195038d..0cca2c95a091 100644
> --- a/arch/metag/kernel/process.c
> +++ b/arch/metag/kernel/process.c
> @@ -419,7 +419,7 @@ unsigned long __metag_elf_map(struct file *filep, unsigned long addr,
>  
>  	if ((type & MAP_FIXED_NOREPLACE) && BAD_ADDR(map_addr))
>  		pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n",
> -				task_pid_nr(current), tsk->comm, (void *)addr);
> +				task_pid_nr(current), current->comm, (void *)addr);
>  
>  	if (!BAD_ADDR(map_addr) && tcm_tag != TCM_INVALID_TAG) {
>  		struct tcm_allocation *tcm;
> -- 
> 2.15.1
> 
> -- 
> Michal Hocko
> SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-metag" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux Wireless]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux