Hi Michal, On Thu, May 11, 2017 at 09:39:15AM +0200, Michal Hocko wrote: > On Wed 10-05-17 16:36:20, James Hogan wrote: > > Since commit 1f5307b1e094 ("mm, vmalloc: properly track vmalloc users"), > > linux/vmalloc.h includes asm/pgtable.h prior to declaring struct > > vm_area_struct, resulting in warnings such as the following on metag: > > > > In file included from ./include/linux/vmalloc.h:10, > > from lib/ioremap.c:9: > > ./arch/metag/include/asm/pgtable.h:221: warning: ‘struct vm_area_struct’ declared inside parameter list > > ./arch/metag/include/asm/pgtable.h:221: warning: its scope is only this definition or declaration, which is probably not what you want > > > > Metag's asm/pgtable.h doesn't actually need the definition of struct > > vm_area_struct, so just declare struct vm_area_struct in the header > > rather than including linux/mm_types.h. > > This will be fixed in a different way [1]. It just waits for Andrew to > send the patch to Linus. > > [1] http://lkml.kernel.org/r/20170509153702.GR6481@xxxxxxxxxxxxxx Okay cool. I'll drop this patch then. Thanks James
Attachment:
signature.asc
Description: Digital signature