On Tue, May 03, 2016 at 10:52:46AM +0200, Peter Zijlstra wrote: > On Tue, May 03, 2016 at 09:40:59AM +0100, James Hogan wrote: > > The argument i of atomic_*_return() operations is given to inline asm > > with the "bd" constraint, which means "An Op2 register where Op1 is a > > data unit register and the instruction supports O2R", however Op1 is > > constrained by "da" which allows an address unit register to be used. > > > > Fix the constraint to use "br", meaning "An Op2 register and the > > instruction supports O2R", i.e. not requiring Op1 to be a data unit > > register. > > > > Fixes: d6dfe2509da9 ("locking,arch,metag: Fold atomic_ops") > > Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx> > > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > > Cc: linux-metag@xxxxxxxxxxxxxxx > > Thanks James, I'd give an ack, but I really don't know about these funny > constraints you have, so I'm not sure it'd actually mean something. No problem, meta is quite a quirky and non-orthogonal architecture. I've applied anyway. Thanks James
Attachment:
signature.asc
Description: Digital signature