On Fri, Sep 19, 2014 at 12:21:37PM +0100, James Hogan wrote:
> Hi Chuck,
>
> On 16/09/14 08:37, Chuck Ebbert wrote:
> > static inline unsigned long *end_of_stack(struct task_struct *p)
> > {
> > +#ifdef CONFIG_STACK_GROWSUP
> > + return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1;
>
> Nit: this line should probably be wrapped to 80 columns.
>
> Other than that, I've tested this on metag and can confirm that it fixes
> the following BUG which you would otherwise get during boot with Aaron's
> patches:
>
> BUG: failure at kernel/sched/core.c:2664/schedule_debug()!
> Kernel panic - not syncing: BUG!
>
> Tested-by: James Hogan <james.hogan@xxxxxxxxxx> [metag]
> Acked-by: James Hogan <james.hogan@xxxxxxxxxx>
OK.
Acked-by: Aaron Tomlin <atomlin@xxxxxxxxxx>
> Aaron: please can you try to get this patch applied before your patch
> series.
Ingo,
I hope it's not too late to get this patch in (once the nit has been
addressed) for CONFIG_STACK_GROWSUP?
Regards,
--
Aaron Tomlin
--
To unsubscribe from this list: send the line "unsubscribe linux-metag" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
