On Thu, Jul 17, 2014 at 04:26:26PM +0300, Andrey Utkin wrote:
> [linux-3.16-rc5/arch/metag/kernel/cachepart.c:102]: (style) Checking if unsigned variable 'thread_cache_size' is less than zero.
>
> Source code is
>
> if (thread_cache_size < 0)
> pr_emerg("Can't read %s cache size\n",
> cache_type ? "DCACHE" : "ICACHE");
>
> but
>
> unsigned int thread_cache_size;
>
> Function get_thread_cache_size returns an error code
> as (unsigned int) -1.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80361
> Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>
> ---
> arch/metag/kernel/cachepart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/metag/kernel/cachepart.c b/arch/metag/kernel/cachepart.c
> index 0a2385f..b137034 100644
> --- a/arch/metag/kernel/cachepart.c
> +++ b/arch/metag/kernel/cachepart.c
> @@ -99,7 +99,7 @@ void check_for_cache_aliasing(int thread_id)
> for (cache_type = ICACHE; cache_type <= DCACHE; cache_type++) {
> thread_cache_size =
> get_thread_cache_size(cache_type, thread_id);
> - if (thread_cache_size < 0)
> + if (thread_cache_size == (unsigned int)-1)
Oh, wow. Every single variable in this file is an unsigned int. :P
We should just make this int. The values of thread_cache_size do not
go that high.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-metag" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
