From: Ken Helias <kenhelias@xxxxxxxxxxx> Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias <kenhelias@xxxxxxxxxxx> Cc: linux-metag@xxxxxxxxxxxxxxx --- arch/metag/kernel/dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/metag/kernel/dma.c b/arch/metag/kernel/dma.c index c700d62..8b384d8 100644 --- a/arch/metag/kernel/dma.c +++ b/arch/metag/kernel/dma.c @@ -138,7 +138,7 @@ found: /* * Insert this entry _before_ the one we found. */ - list_add_tail(&new->vm_list, &c->vm_list); + list_add_before(&new->vm_list, &c->vm_list); new->vm_start = addr; new->vm_end = addr + size; new->vm_active = 1; -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-metag" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html