On Wednesday 23 April 2014, James Hogan wrote: > The new renameat2 syscall provides all the functionality provided by the > renameat syscall and adds flags, so future architectures won't need to > include renameat. > > Therefore drop the renameat syscall from the generic syscall list unless > __ARCH_WANT_RENAMEAT is defined by the architecture's unistd.h prior to > including asm-generic/unistd.h, and adjust all architectures using the > generic syscall list to define it so that no in-tree architectures are > affected. I should have read this one before replying to patch 2 ;-) > Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx> > Cc: linux-arch@xxxxxxxxxxxxxxx > Cc: Vineet Gupta <vgupta@xxxxxxxxxxxx> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx> > Cc: Will Deacon <will.deacon@xxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: Mark Salter <msalter@xxxxxxxxxx> > Cc: Aurelien Jacquiot <a-jacquiot@xxxxxx> > Cc: linux-c6x-dev@xxxxxxxxxxxxx > Cc: Richard Kuo <rkuo@xxxxxxxxxxxxxx> > Cc: linux-hexagon@xxxxxxxxxxxxxxx > Cc: linux-metag@xxxxxxxxxxxxxxx > Cc: Jonas Bonn <jonas@xxxxxxxxxxxx> > Cc: linux@xxxxxxxxxxxxxxxxxx > Cc: Chen Liqin <liqin.linux@xxxxxxxxx> > Cc: Lennox Wu <lennox.wu@xxxxxxxxx> > Cc: Chris Metcalf <cmetcalf@xxxxxxxxxx> > Cc: Guan Xuetao <gxt@xxxxxxxxxxxxxxx> > --- > Is this the approach we want to take to keep the default syscall list > minimal? We could for example have made renameat2 use the renameat > syscall number for new arches, but it seemed best to leave a gap for new > arches to improve consistency of numbering. I think leaving the hole is best. > This patch is a no-op for arches in tree, so there's no harm for this to > wait for the v3.16 merge window. Sounds good. I guess I'll have to put this into my asm-generic tree then, unless I can get the nios2 maintainers to pick it up. If you don't mind, can you submit the first two patches to Linus directly? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-metag" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html