On 04/22/2016 03:03 PM, Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > The adv7180 attempts to autodetect the standard. Unfortunately this > is seriously broken. > > This patch removes the autodetect completely. Only the querystd op > will detect the standard. Since the design of the adv7180 requires > that you switch to a special autodetect mode you cannot call querystd > when you are streaming. > > So the s_stream op has been added so we know whether we are streaming > or not, and if we are, then querystd returns EBUSY. > > After testing this with a signal generator is became obvious that > a sleep is needed between changing the standard to autodetect and > reading the status. So the autodetect can never have worked well. > > The s_std call now just sets the new standard without any querying. > > If the driver supports the interrupt, then when it detects a standard > change it will signal that by sending the V4L2_EVENT_SOURCE_CHANGE > event. > > With these changes this driver now behaves like all other video > receivers. > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > Cc: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > Cc: Lars-Peter Clausen <lars@xxxxxxxxxx> > Cc: Federico Vaga <federico.vaga@xxxxxxxxx> Thanks for cleaning this up. Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
