Hello Mauro, The patch looks mostly good to me, I just have a question below: On Wed, Mar 16, 2016 at 9:04 AM, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> wrote: [snip] > > -void media_device_cleanup(struct media_device *mdev) > +static void media_device_cleanup(struct media_device *mdev) > { > ida_destroy(&mdev->entity_internal_idx); > mdev->entity_internal_idx_max = 0; > media_entity_graph_walk_cleanup(&mdev->pm_count_walk); > - mutex_destroy(&mdev->graph_mutex); Any reason why this is removed? mutex_init() is still called in media_device_init() so I believe the destroy should be kept here. Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html