On 03/11/2016 09:52 AM, Shuah Khan wrote: > On 03/11/2016 09:34 AM, Mauro Carvalho Chehab wrote: >> Em Fri, 11 Mar 2016 09:27:40 -0700 >> Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> escreveu: >> >>> On 03/11/2016 08:55 AM, Mauro Carvalho Chehab wrote: >>>> For au0828_enable_source() to work, the tuner links should be >>>> disabled and the tuner/decoder should be cached at au0828 struct. >>> >>> hmm. are you sure about needing to cache decoder in au0828 struct. >>> It gets cached in au0828_card_analog_fe_setup() which is called >>> from au0828_card_setup() - this step happens before >>> au0828_media_device_register() >>> >>> #ifdef CONFIG_MEDIA_CONTROLLER >>> if (sd) >>> dev->decoder = &sd->entity; >>> #endif >> >> I haven't check it. Yet, I guess the best would be to put those >> caches all at au0828_media_device_register(). This way, it would be >> easier to remember removing them, once we move au0828_enable_source >> to the core. > > Yes. Consolidating caches in one place is a good idea. One thing we > have to keep in mind when we do that is the !MEDIA_CONTROLLER cases. > The above cached value could be used even when MEDIA_CONTROLLER isn't > enabled. Never mind - the second comment isn't valid! We are setting this in ifdef CONFIG_MEDIA_CONTROLLER :) thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
