Hi, after applying this patchset gspca passes all v4l2-compliance tests, at least it does with a PS3 Eye. - Patch 1 removes some magic numbers in subdrivers. - Patch 2 is a correctness fix, but it does not bring any functional changes. - Patch 3 is a readability improvement by itself, but it's also a preliminary change for patch 4. - Patches from 4 to 7 are the actual compliance fixes. More details are in the commit messages. Thanks, Antonio Antonio Ospite (7): [media] gspca: ov534/topro: use a define for the default framerate [media] gspca: fix setting frame interval type in vidioc_enum_frameintervals() [media] gspca: rename wxh_to_mode() to wxh_to_nearest_mode() [media] gspca: fix a v4l2-compliance failure about VIDIOC_ENUM_FRAMEINTERVALS [media] gspca: fix a v4l2-compliance failure about buffer timestamp [media] gspca: fix a v4l2-compliance failure during VIDIOC_REQBUFS [media] gspca: fix a v4l2-compliance failure during read() drivers/media/usb/gspca/gspca.c | 36 +++++++++++++++++++++++------------- drivers/media/usb/gspca/ov534.c | 7 +++---- drivers/media/usb/gspca/topro.c | 6 ++++-- 3 files changed, 30 insertions(+), 19 deletions(-) -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html