Re: [PATCH] media: sh_mobile_ceu_camera, rcar_vin: Use ARCH_RENESAS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

Oops, seems I dropped all CCs in my earlier reply. Fixing up...

On Mon, Mar 7, 2016 at 2:28 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Thu, Mar 03, 2016 at 09:40:07AM +0100, Geert Uytterhoeven wrote:
>> On Thu, Mar 3, 2016 at 2:52 AM, Simon Horman <horms+renesas@xxxxxxxxxxxx> wrote:
>> > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
>> >
>> > This is part of an ongoing process to migrate from ARCH_SHMOBILE to
>> > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
>> > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
>> >
>> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
>>
>> > --- a/drivers/media/platform/soc_camera/Kconfig
>> > +++ b/drivers/media/platform/soc_camera/Kconfig
>> > @@ -36,7 +36,7 @@ config VIDEO_PXA27x
>> >  config VIDEO_RCAR_VIN
>> >         tristate "R-Car Video Input (VIN) support"
>> >         depends on VIDEO_DEV && SOC_CAMERA
>> > -       depends on ARCH_SHMOBILE || COMPILE_TEST
>> > +       depends on ARCH_RENESAS || COMPILE_TEST
>>
>> OK
>>
>> >>  config VIDEO_SH_MOBILE_CEU
>> >         tristate "SuperH Mobile CEU Interface driver"
>> >         depends on VIDEO_DEV && SOC_CAMERA && HAS_DMA && HAVE_CLK
>> > -       depends on ARCH_SHMOBILE || SUPERH || COMPILE_TEST
>> > +       depends on ARCH_RENESAS || SUPERH || COMPILE_TEST
>>
>> I think dropping the SUPERH dependency is the right approach here, as all
>> SuperH platforms using this driver select ARCH_SHMOBILE.
>>
>> "sh_mobile_ceu" is used on SH_AP325RXA, SH_ECOVEC, SH_KFR2R09, SH_MIGOR,
>> and SH_7724_SOLUTION_ENGINE, which depend on either CPU_SUBTYPE_SH7722,
>>  CPU_SUBTYPE_SH7723, or
>> CPU_SUBTYPE_SH7724, and all three select ARCH_SHMOBILE.
>
> Dropping SUPERH seems fine to me. But in that case I think the following
> would be best as I would like to stop selecting ARCH_SHMOBILE for
> the ARM SoCs.
>
>         depends on ARCH_RENESAS || ARCH_SHMOBILE || COMPILE_TEST

Do we need this driver with ARCH_RENESAS? It does not support DT.

R8a7740 has the sh_mobile_ceu hardware, but support for it was dropped with
r8a7740/armadillo legacy removal.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux